[Refactor] Centralize Translate Test architecture #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Translate Test needs a lot of love. The first step is to make sure no code lives outside of
ndsl
that should be back to the mothership. This pullspyFV3
andpySHiELD
code that should not be there.pyFV3
andpySHiELD
will break and need to be adapted. Namely thereconftest
needs to importndsl.conftest
Other change to allow for an easier "from scratch" experience for testing are:
--dperiodic
is removed, replaced with a--layout
option withcube
andtile
as values to describe which grid the test needs--compute_grid
is removed and extended by--grid
option withfile
(default),compute
(replaces--compute_grid
anddefault
which allows to run a test with noGrid-Info.nc
present on a simplenpx/npy/npz
grid with no metric terms.dat
tonetcdf
is now inndsl
and available on the command line withndsl-serialbox_to_netcdf
How Has This Been Tested?
This comes around as we are building 101 notebooks. In the series, we are showing how to port Fortran code and are making a translate test from scratch, which prompted and tested those changes.
Checklist: