Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent seaice.stats at CommerceGov/NOAA-GFDL-MOM6@670384f65 #1

Closed
adcroft opened this issue Jun 27, 2014 · 0 comments
Closed

Inconsistent seaice.stats at CommerceGov/NOAA-GFDL-MOM6@670384f65 #1

adcroft opened this issue Jun 27, 2014 · 0 comments
Assignees
@Hallberg-NOAA
Labels
bug question

Comments

@adcroft
Copy link
Member

adcroft commented Jun 27, 2014

Between commits mom-ocean/MOM6@9d8fbe0 and mom-ocean/MOM6@670384f I am now seeing the following differences in all SIS2 examples (only one pasted below). The differences are not continuous which suggests either round-off OR a PE-count dependent sum?

diff --git a/examples/ocean_SIS2/Baltic/SIS_parameter_doc.short b/examples/ocean_SIS2/Baltic/SIS_parameter_doc.short
index 5a5aea9..e5c220b 100644
--- a/examples/ocean_SIS2/Baltic/SIS_parameter_doc.short
+++ b/examples/ocean_SIS2/Baltic/SIS_parameter_doc.short
@@ -1,7 +1,3 @@
-SNOW_ALBEDO = 0.88 ! [nondim] default = 0.85

  •                            ! The albedo of dry snow atop sea ice.
    -ICE_ALBEDO = 0.68 ! [nondim] default = 0.5826
  •                            ! The albedo of dry bare sea ice.
    ICE_BULK_SALINITY = 0.005 ! [kg/kg] default = 0.004
    ! The fixed bulk salinity of sea ice.
    ICE_STATS_INTERVAL = 0.25 ! [days] default = 1.0
    diff --git a/examples/ocean_SIS2/Baltic/seaice.stats.gnu b/examples/ocean_SIS2/Baltic/seaice.stats.gnu
    index be5ee83..cd004b2 100644
    --- a/examples/ocean_SIS2/Baltic/seaice.stats.gnu
    +++ b/examples/ocean_SIS2/Baltic/seaice.stats.gnu
    @@ -2,11 +2,11 @@
    [days] [m2] [m2] [kg] [J] [g/kg] [Nondim] [Nondim] [Nondim]
    0, 0.000, Area 0.000000000000E+00 0.000000000000E+00, Ext 0.0000E+00 0.0000E+00, M 0.00000E+00 0.00000E+00, Enth 0.00000E+00 0.00000E+00, S 0.0000 0.0000, Me 0.00E+00, Te 0.00E+00, Se 0.00E+00
    3, 0.250, Area 5.583302752895E+10 0.000000000000E+00, Ext 5.5838E+10 0.0000E+00, M 3.65239E+13 0.00000E+00, Enth -9.83314E+18 0.00000E+00, S 4.9999 0.0000, Me 9.52E-17, Te 2.66E-16, Se -1.00E-16
  • 6,       0.500, Area 5.590309410697E+10 0.000000000000E+00, Ext 6.2662E+10 0.0000E+00, M 3.61292E+13 0.00000E+00, Enth -9.75807E+18  0.00000E+00, S   4.9991  0.0000, Me -1.79E-17, Te  9.54E-17, Se  3.79E-17

  • 6,       0.500, Area 5.590309410697E+10 0.000000000000E+00, Ext 6.2662E+10 0.0000E+00, M 3.61292E+13 0.00000E+00, Enth -9.75807E+18  0.00000E+00, S   4.9991  0.0000, Me -1.80E-17, Te  9.55E-17, Se  3.79E-17
    9, 0.750, Area 5.580825359426E+10 0.000000000000E+00, Ext 6.2662E+10 0.0000E+00, M 3.49912E+13 0.00000E+00, Enth -9.49826E+18 0.00000E+00, S 4.9976 0.0000, Me 1.03E-16, Te -1.72E-16, Se 2.01E-17
    12, 1.000, Area 5.568831542652E+10 0.000000000000E+00, Ext 7.6845E+10 0.0000E+00, M 3.35011E+13 0.00000E+00, Enth -9.14122E+18 0.00000E+00, S 4.9955 0.0000, Me 7.65E-17, Te 2.13E-16, Se -5.98E-17
    15, 1.250, Area 5.499135731927E+10 0.000000000000E+00, Ext 6.9842E+10 0.0000E+00, M 3.22486E+13 0.00000E+00, Enth -8.83726E+18 0.00000E+00, S 4.9931 0.0000, Me -7.32E-17, Te 1.14E-16, Se 2.87E-17
  • 18, 1.500, Area 5.471180319680E+10 0.000000000000E+00, Ext 6.9842E+10 0.0000E+00, M 3.10175E+13 0.00000E+00, Enth -8.53320E+18 0.00000E+00, S 4.9906 0.0000, Me 8.99E-17, Te 8.55E-17, Se -1.05E-16
  • 18, 1.500, Area 5.471180319680E+10 0.000000000000E+00, Ext 6.9842E+10 0.0000E+00, M 3.10175E+13 0.00000E+00, Enth -8.53320E+18 0.00000E+00, S 4.9906 0.0000, Me 8.99E-17, Te 8.56E-17, Se -1.05E-16
    21, 1.750, Area 5.458039180398E+10 0.000000000000E+00, Ext 6.9842E+10 0.0000E+00, M 2.94415E+13 0.00000E+00, Enth -8.13975E+18 0.00000E+00, S 4.9886 0.0000, Me -3.46E-17, Te -6.29E-17, Se -3.36E-17
    24, 2.000, Area 5.355904887448E+10 0.000000000000E+00, Ext 7.6668E+10 0.0000E+00, M 2.77632E+13 0.00000E+00, Enth -7.72257E+18 0.00000E+00, S 4.9869 0.0000, Me 2.26E-19, Te 6.30E-17, Se 3.11E-17
    27, 2.250, Area 5.310654194288E+10 0.000000000000E+00, Ext 7.6668E+10 0.0000E+00, M 2.60318E+13 0.00000E+00, Enth -7.29088E+18 0.00000E+00, S 4.9845 0.0000, Me -7.89E-17, Te -1.97E-16, Se -1.94E-17
    @@ -19,5 +19,5 @@
    48, 4.000, Area 4.791283108200E+10 0.000000000000E+00, Ext 5.5838E+10 0.0000E+00, M 1.80926E+13 0.00000E+00, Enth -5.22057E+18 0.00000E+00, S 4.9690 0.0000, Me -1.30E-16, Te -6.01E-16, Se -2.83E-18
    51, 4.250, Area 4.078733016622E+10 0.000000000000E+00, Ext 4.9194E+10 0.0000E+00, M 1.74075E+13 0.00000E+00, Enth -5.02966E+18 0.00000E+00, S 4.9665 0.0000, Me 3.44E-17, Te -3.76E-16, Se 8.47E-17
    54, 4.500, Area 3.860636645046E+10 0.000000000000E+00, Ext 4.2370E+10 0.0000E+00, M 1.69088E+13 0.00000E+00, Enth -4.88980E+18 0.00000E+00, S 4.9663 0.0000, Me 2.51E-17, Te -2.20E-16, Se 5.40E-18
  • 57, 4.750, Area 3.854805314671E+10 0.000000000000E+00, Ext 4.2370E+10 0.0000E+00, M 1.66219E+13 0.00000E+00, Enth -4.81558E+18 0.00000E+00, S 4.9637 0.0000, Me -6.20E-17, Te 1.33E-16, Se -3.03E-17
  • 60, 5.000, Area 3.468216626754E+10 0.000000000000E+00, Ext 3.5546E+10 0.0000E+00, M 1.63553E+13 0.00000E+00, Enth -4.74558E+18 0.00000E+00, S 4.9638 0.0000, Me 4.15E-17, Te 4.30E-17, Se 2.71E-18
  • 57, 4.750, Area 3.854805314671E+10 0.000000000000E+00, Ext 4.2370E+10 0.0000E+00, M 1.66219E+13 0.00000E+00, Enth -4.81558E+18 0.00000E+00, S 4.9637 0.0000, Me -6.20E-17, Te 1.08E-16, Se -3.93E-17
  • 60, 5.000, Area 3.468216626754E+10 0.000000000000E+00, Ext 3.5546E+10 0.0000E+00, M 1.63553E+13 0.00000E+00, Enth -4.74558E+18 0.00000E+00, S 4.9638 0.0000, Me -1.02E-17, Te 4.98E-17, Se 1.56E-16
    diff --git a/examples/ocean_SIS2/Baltic/timestats.gnu b/examples/ocean_SIS2/Baltic/timestats.gnu
    index f7e1a8a..d578730 100644
    --- a/examples/ocean_SIS2/Baltic/timestats.gnu
    +++ b/examples/ocean_SIS2/Baltic/timestats.gnu
    @@ -20,4 +20,4 @@
    51, 4.250, 0, En 2.008558287041E+00, CFL 0.02449, SL 8.6388E-03, M 6.43236E+16, S 23.8172, T 6.9976, Me 1.09E-13, Se 3.46E-12, Te 1.08E-12
    54, 4.500, 0, En 1.986528442226E+00, CFL 0.02654, SL 8.3321E-03, M 6.43229E+16, S 23.8175, T 6.9828, Me 9.77E-14, Se 3.09E-12, Te 9.45E-13
    57, 4.750, 0, En 2.349048070339E+00, CFL 0.02707, SL 8.1877E-03, M 6.43226E+16, S 23.8176, T 6.9681, Me 9.64E-14, Se 3.06E-12, Te 9.32E-13
  • 60, 5.000, 0, En 2.342973129879E+00, CFL 0.02520, SL 8.0442E-03, M 6.43224E+16, S 23.8177, T 6.9535, Me 9.63E-14, Se 3.06E-12, Te 9.35E-13
  • 60, 5.000, 0, En 2.342964973917E+00, CFL 0.02520, SL 8.0442E-03, M 6.43224E+16, S 23.8177, T 6.9535, Me 9.63E-14, Se 3.06E-12, Te 9.36E-13
@adcroft adcroft closed this as completed Nov 13, 2014
nikizadehgfdl added a commit that referenced this issue Mar 21, 2016
@nikizadehgfdl
frazil_cat size is wrong
1f531cc 
Running single column test in debug mode found this issue (which causes a crash in prod mode):
```
forrtl: severe (408): fort: (2): Subscript #1 of the array FRAZIL_CAT has value 5 which is greater than the upper bound of 4
Image              PC                Routine            Line        Source
fms_SIS2_OCEANMIX  000000000077C3B6  ice_model_mod_mp_        3265  ice_model.F90
fms_SIS2_OCEANMIX  0000000000646612  ice_model_mod_mp_        1777  ice_model.F90
fms_SIS2_OCEANMIX  00000000005310AE  ice_model_mod_mp_         138  ice_model.F90
fms_SIS2_OCEANMIX  000000000040E356  MAIN__                    875  coupler_main.F90
```

frazil_cat size is wrong.
@adcroft adcroft mentioned this issue Sep 7, 2017
Merged
adcroft pushed a commit that referenced this issue Sep 8, 2017
@Hallberg-NOAA
Merge pull request #1 from Hallberg-NOAA/coupler_type_reform_rwh
6995ce7 
Merge in Coupler type reform rwh
MJHarrison-GFDL pushed a commit to MJHarrison-GFDL/SIS2 that referenced this issue May 24, 2021
@kshedstrom
Merge pull request NOAA-GFDL#1 from MJHarrison-GFDL/Icepack
b662f69 
Icepack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hallberg-NOAA Hallberg-NOAA

Labels
bug question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adcroft @Hallberg-NOAA