SIS2: Revise SIS2 restart capability #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensively revised SIS_restart.F90 to read and write restart files using the MOM_io routines and avoiding the direct use of any FMS routines, which enables the migration to use the new FMS2 I/O interfaces while still maintaining the ability to run with the traditional FMS I/O interfaces. All solutions are bitwise identical when used with either of the MOM6 config_src/infra directories (although there are some changes in the output file metadata), and the SIS2 runs in MOM6-examples with the new restart files reproduce answers when either I/O via the root PE or parallel I/O are used. The interfaces that are used from outside the SIS_restart module are unchanged, although there are some minor changes to internal interfaces.
Corrected the arguments in a call to open_file in open_restart_units when the restart files are decomposed using the IO-layout. All answers are bitwise identical, but this fixes an error later on if this unit handle is used to read from such a set of decomposed restart files.
This was referenced Apr 23, 2021
|
This has passed my local (non-restart) regression as well as a proxy restart test thrown together, based on OM4_025:
This is probably not sufficient for restart testing but should eventually be revealed in the Gaea regression testing. |
|
Gaea regression test (post-merge): https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12546 ✔️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small handful of commits that revise the SIS2 restart
capability to read and write without using any FMS routines directly, which
enables the migration to use the new FMS2 I/O interfaces while still maintaining
the ability to run with the traditional FMS I/O interfaces. All solutions are
bitwise identical when used with either of the MOM6 config_src/infra directories
(although there are some changes in the output file metadata), and the SIS2 runs
in MOM6-examples with the new restart files reproduce answers when either I/O
via the root PE or parallel I/O are used.
This SIS2 PR requires the use of MOM6 code with the changes in https://github.com/NOAA-GFDL/MOM6/pull/1373 .
The commits in this PR include: