Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and data_override logic updates #16

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

bensonr
Copy link
Contributor

@bensonr bensonr commented Mar 10, 2022

Description
Fixes a bug in SHiELD/atmos_model for variable initialization.
In solo/atmos_model:

  • updates module use handling
  • removes outdated logic for data_override_init handling
  • gives calendar an initial value

DEPENDENCY ON FMS PR #933

Fixes # (issue)

How Has This Been Tested?
This has been tested in FV3 solo tests to ensure proper handling of data_override_init with no grid_spec and an empty data_table. The variable initialization bug in SHiELD has been tested in a SHiELD run.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included

call atmosphere_init (Time_init, Time, Time_step_atmos)
call atmosphere_domain(atmos_domain)

call data_override_init(Atm_domain_in = atmos_domain)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work in Regional runs? Do we need an if bounded domain?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurenchilutti - it might still be needed if someone does actually try to use data_override with a bounded domain independent of the existence of the grid_spec. I'll add it back in for the appropriate function calls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at this further, this is for the solo runs and I don't think we'll be using any data_overrides in this system. Maybe it makes sense to go with the original and not include data_override_init.

@bensonr bensonr requested a review from laurenchilutti March 10, 2022 16:06
@rem1776 rem1776 merged commit 81768a1 into NOAA-GFDL:main Mar 31, 2022
@bensonr bensonr deleted the data_override branch April 14, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

4 participants