Pass the namelist variables from the dycore to the physics during the initialization #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during the initialization.
…o the physics during the initialization.
linjiongzhou
requested review from
laurenchilutti and
thomas-robinson
as code owners
|
Hi @laurenchilutti, this merge will only work with the recent updates in the atmos_cubed_sphere and fv3_gfsphysics. Those updates are under review by @spencerkclark and @lharris4. |
spencerkclark
approved these changes
May 3, 2023
lharris4
approved these changes
May 3, 2023
| @@ -473,6 +475,10 @@ subroutine atmos_model_init (Atmos, Time_init, Time, Time_step, iau_offset) | |||
| Init_parm%xlat => Atmos%lat | |||
| Init_parm%area => Atmos%area | |||
| Init_parm%tracer_names => tracer_names | |||
| !--- setup IPD_Control | |||
There was a problem hiding this comment.
This is indeed very clean.
laurenchilutti
approved these changes
May 3, 2023
This was referenced May 4, 2023
|
Hi,all. Did this ever get merged? |
|
No, this hasnt been merged. I plan to merge this at the same time as the public release code (which should be coming this week) |
|
Hi, Lauren. Thanks for your update.
Lucas
…On Mon, May 22, 2023 at 7:13 AM laurenchilutti ***@***.***> wrote:
No, this hasnt been merged. I plan to merge this at the same time as the
public release code (which should be coming this week)
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMUQRVHW4L2PWSXKLY2ZHHTXHNC4FANCNFSM6AAAAAAXUUCJMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This was referenced Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dynamical core and physics package share some namelist variables. In the current model codebase, these namelist variables are either passed from the dynamical core to the physics package after the initialization or duplicated in the physics package. This produces a potential issue that the physics initialization does not see the dynamical core namelist and leads to errors.
Fixes # (issue)
No issue with this atmos_drivers. We need some code changes in atmos_drivers so that our update of the dynamical core and physics package will work.
How Has This Been Tested?
It was tested and the results are expected. The issue has been resolved.
Checklist: