Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imbalance tolerance to a namelist #27

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Add imbalance tolerance to a namelist #27

merged 2 commits into from
Dec 4, 2023

Conversation

nikizadehgfdl
Copy link
Contributor

  • imbalance tolerance needs to be adjustable
  • It usually depends on the compute platform/compiler

@nikizadehgfdl nikizadehgfdl requested a review from jessluo December 1, 2023 16:08
@jessluo
Copy link

jessluo commented Dec 1, 2023

Hi Niki, This looks great. Making the tolerance level a namelist variable is very much needed, given how many times the source/sink imbalance line gets tripped up. I wonder if we can also pull this into dev4.2?

Jessica

jessluo
jessluo approved these changes Dec 1, 2023
View reviewed changes
Copy link

@jessluo jessluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nikizadehgfdl nikizadehgfdl merged commit 011b724 into NOAA-GFDL:master Dec 4, 2023
kshedstrom pushed a commit to ESMG/ocean_BGC that referenced this pull request Apr 12, 2024
@charliestock
added felim to diazo iron limitation to address issue NOAA-GFDL#27 (N…
d4e20e4 
…OAA-GFDL#31)

Co-authored-by: Charles Stock <Charles.Stock@an002.princeton.rdhpcs.noaa.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessluo jessluo jessluo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikizadehgfdl @jessluo