forked from MPAS-Dev/MPAS-Model
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUC LSM is split into land and ice parts. #21
Merged
jderrico-noaa
merged 8 commits into
NOAA-GSL:gsl/develop
from
tanyasmirnova:ruc_land_ice
May 24, 2024
Merged
RUC LSM is split into land and ice parts. #21
jderrico-noaa
merged 8 commits into
NOAA-GSL:gsl/develop
from
tanyasmirnova:ruc_land_ice
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, call to ruc_sfcdiags is moved from the lsm driver to seaice driver.
call are done now from driver_seaice. Results are identical with the previous version.
consistent with NCAR MPAS.
jderrico-noaa
requested review from
joeolson42,
haiqinli,
mdtoyNOAA and
AndersJensen-NOAA
May 23, 2024 18:56
joeolson42
approved these changes
May 23, 2024
haiqinli
approved these changes
May 24, 2024
jderrico-noaa
added a commit
that referenced
this pull request
May 29, 2024
This reverts commit 23ebf24.
jderrico-noaa
added a commit
that referenced
this pull request
May 29, 2024
AndersJensen-NOAA
pushed a commit
to AndersJensen-NOAA/MPAS-Model
that referenced
this pull request
Oct 3, 2024
Fix UGWP hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title above should be a 1 line short summary of the pull request (i.e. what the project the PR represents is intended to do).
RUC LSM is split into land and ice parts.
Enter a description of this PR. This should include why this PR was created, and what it does.
MPAS 8.1 has a new driver that calls Noah ice scheme. To accommodate this change, RUC LSM has been split into two parts: one for land, and another for sea ice. The land part is called from the driver_lsm, the ice part is called from the driver_seaice.
Testing and relations to other Pull Requests should be added as subsequent comments.
Testing produced identical results with the previous version.
See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931