Exceedance code to output comparisons of QPF with Flash Flood Guidance #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erval (ARI) precipitation datasets for comparison with model QPF within UPP.
hu5970
reviewed
Jul 6, 2021
sorc/ncep_post.fd/RQSTFLD.F
Outdated
| & '6H 50Y ARI ON surface '/ | ||
| DATA IFILV(925),AVBL(925),IQ(925),IS(925),AVBLGRB2(925) & | ||
| & /1,'6H 100Y ARI EXCEDNCE',166,001, & | ||
| & '6H 100Y ARI ON surface'/ | ||
| ! CD and CH exchange coefficients |
There was a problem hiding this comment.
This piece of the code is for grib1 but grib1 is not in UPP anymore.
So we don't need to change code in RQSTFLD.F
You can delete this part.
hu5970
approved these changes
Jul 6, 2021
|
@EricJames-NOAA Please clean the code based on my comment and merge the code. We can use the current code to start merge with EMC develop. But if we want to commit our code back to EMC development branch, we may need to do more work to improve the code. We can leave this when we talk about commit code back to EMC. |
|
Thanks for the comments @hu5970 ! Yes, the code could be improved I'm sure. My focus was just to get something that works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is to output gridded binary fields indicating where model QPF exceeds Flash Flood Guidance (FFG) for 1h, 3h, 6h, and 12h accumulation periods. SURFCE.f and grib2_module.f were modified to read in FFG GRIB2 files (available on /public) and do the comparison. Flat files were also modified to add the four new exceedance fields.
Code was tested both in a stand-alone UPP setup, and in a full RRFS-dev1 like deployment in my own space (in combination with small modifications to exregional_run_post.sh in the regional_workflow repository, which is a separate pull request).