Added TTL and max length to _setup_queue for any private confirm queu… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geary-Layne
approved these changes
Nov 17, 2023
| @@ -317,8 +317,12 @@ def _setup_queue(self, queue: Queue): | |||
| :param str|unicode queue_name: The name of the queue to declare. | |||
| """ | |||
| logger.debug('Declaring queue %s', queue.name) | |||
| args = {} | |||
There was a problem hiding this comment.
Could you add a comment about what it means when a queue name starts with '_' and what the args will do?
|
Sure.
…On Fri, Nov 17, 2023 at 12:50 PM Geary-Layne ***@***.***> wrote:
***@***.**** approved this pull request.
Looks simple enough
------------------------------
In python/idsse_common/idsse/common/publish_confirm.py
<#35 (comment)>
:
> @@ -317,8 +317,12 @@ def _setup_queue(self, queue: Queue):
:param str|unicode queue_name: The name of the queue to declare.
"""
logger.debug('Declaring queue %s', queue.name)
+ args = {}
Could you add a comment about what it means when a queue name starts with
'_' and what the args will do?
—
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATO5PJNB3E6P4TSO3JMU2WTYE65WHAVCNFSM6AAAAAA7QGPZOKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZXGY4DANRQHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Paul Hamer
<http://www.esrl.noaa.gov/fiqas/>
Global Systems Laboratory (GSL)
325 Broadway R/GS5
Boulder, CO 80305-3328
|
…will remove messages older than 10 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes to add TTL and max length for private queues. Oh and a few spelling updates. ;-)