Chore: fix expected data in test_geo_image #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geary-Layne
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear Issue
N/A
Changes
A few unit tests in the main branch, and had been since PR #47 was merged.
I modified the expected values slightly in
test_geo_image.pyso that they pass. Not clear what code changes in geo_image.py caused these to fail, but in most cases the value was only shifted by a few pixels.Also have no idea why the GitHub Action displays as " ✅ Success", yet running pytest locally, or looking at logs in GitHub on the main branch or on the original branch, outputs these failing tests.