chore: cleanup unneeded references to typing module #63
Conversation
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| class Config: | ||
| """Configuration data class""" | ||
| def __init__(self, | ||
| config: Union[dict, List[dict], str], | ||
| keys: Optional[Union[list, str]] = None, | ||
| config: dict | Iterable[dict] | str, |
There was a problem hiding this comment.
I normally use Sequence but Iterable is likely more correct.
There was a problem hiding this comment.
I thought I read somewhere that Iterable was preferred for arguments because it gives the most flexibility to the caller, whereas Sequence was preferred for return values because it's more specific, and you (hopefully) know what exactly you're returning.
In general I too prefer Sequence.
|
|
||
| from pika import BasicProperties, ConnectionParameters, PlainCredentials | ||
| from pika.adapters import BlockingConnection, blocking_connection | ||
| from pika.adapters import BlockingConnection | ||
| from pika.adapters.blocking_connection import BlockingChannel |
There was a problem hiding this comment.
Getting this explicitly make the code easier to read.
| width: float, | ||
| height: float, | ||
| dx: float, | ||
| dy: Optional[float] = None): | ||
| dy: float | None = None): |
There was a problem hiding this comment.
In a previous file you used dy: float, optional = None
There was a problem hiding this comment.
Good catch. I think the "float, optional" has showed up when I allowed VSCode to auto-generate the docstring, vs. "float | None" is what I typed manually. I'll change this to use "float, optional"
There was a problem hiding this comment.
Oh, figured it out. "optional" means a default value is defined for the argument, vs. "float | None" just means the value can be None. I'll fix these type hints now.
Co-authored-by: Geary-Layne <77741618+Geary-Layne@users.noreply.github.com>
Co-authored-by: Geary-Layne <77741618+Geary-Layne@users.noreply.github.com>
| @@ -28,21 +28,18 @@ | |||
|
|
|||
| def set_corr_id_context_var( | |||
| originator: str, | |||
| key: Optional[uuid.UUID] = None, | |||
| issue_dt: Optional[Union[str, datetime]] = None | |||
| key: uuid.UUID = uuid.uuid4(), | |||
There was a problem hiding this comment.
uuid4() is new to me, I'm guessing that is what we should be using everywhere, I'll try to remember this.
There was a problem hiding this comment.
I just copied code from inside this function, which I think was using uuid4(). I've seen places in our code that alias uuid4() as just uuid(), because it's the most common version people think of when they say "UUID". The format is xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx.
There are other versions of the UUID standard, such as version 1 which uses the current time and the MAC address of the computer to generate a probably unique ID, but I've only ever used v4.
https://en.wikipedia.org/wiki/Universally_unique_identifier#Version_4_(random)
Linear Issue
IDSSE-539
Changes
No logic changes, just removing
typingmodule imports wherever possible and using primitive types (likedictandtuple) for type annotations instead.Explanation
N/A