bug: pass Conn.connection_parameters to pika.BlockingConnection

[mackenzie-grimes-noaa]

Linear Issue

N/A

Changes

• Small bug fix for RabbitMQ Publisher and Consumer class __init__s to pass the right argument type to pika.BlockingConnection.

Explanation

The rabbitmq class property Conn has a property connection_parameters that transforms the NamedTuple that a caller would have created into a pika.ConnectionParameters which pika.BlockingConnection expects. However, we forgot to use this transformation throughout rabbitmq_utils.py.

For example, passing an Conn instance to Publisher() was throwing an uncaught exception:

                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/mackenzie.grimes/dev/idss-engine-commons/python/idsse_common/idsse/common/rabbitmq_utils.py", line 434, in __init__
    self.connection = BlockingConnection(conn_params)

AttributeError: 'str' object has no attribute 'connection_attempts'

because the actual Conn (type: NamedTuple) was being passed to pika.BlockingConnection.

[mackenzie-grimes-noaa]

@Geary-Layne I'm not sure if you intended this change, but Consumer and Publisher inits are currently expecting a pika.ConnectionParameters type object.

If you meant to expect an idsse commons Conn like the previous RabbitMqUtils did, I believe we need this change to transform the Conn into a ConnectionParameters before passing to BlockingConnection.

If not, and you really did want require an arg of pika.ConnectionParameters, we'll need to make sure all services call Conn.connection_parameters before passing to Publisher or Consumer.

[Geary-Layne]

I'm not sure which is best, expecting a Conn or a ConnectionParams, but lets go with Conn, and thus the change you have here. Thanks

[Geary-Layne]

I merged it since I would like to use these changes when fixing the other repos