-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ims-service accepts new profiles #5
Conversation
Code coverage report, since I don't think the GitHub Action is posting changes to the README at this point (and maybe doesn't need to): Name Stmts Miss Cover
----------------------------------------------------------------------------------------------------------
/home/runner/work/idsse-testing/idsse-testing/python/nwsc_proxy/ncp_web_service.py 58 1 98%
/home/runner/work/idsse-testing/idsse-testing/python/nwsc_proxy/src/profile_store.py 85 5 94%
----------------------------------------------------------------------------------------------------------
TOTAL 143 6 96%
============================== 19 passed in 0.56s ============================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I was wondering why you called it NDS vs NPS with proxy for the middle name, you even call it the NWS Connect proxy service in the README.
GSL_KEY = '8209c979-e3de-402e-a1f5-556d650ab889' | ||
|
||
|
||
def to_iso(date_time: datetime) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does any part of idsse-testing us commons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't at the moment. I was afraid to add an import of idss-engine-commons just for to_iso()
and potentially cause a circular dependency in GitHub, because the idsse/testing
directory has an idsse_common
folder with test files, which I thought meant commons imports this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idsse/testing is a package install and other than a small amount of code that imports resources for tests there is no dependency.
I changed my mind on the name mid-development. I'll update everything to call it "NWSC Proxy". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly a lot more useful than what was there before...
Linear Issue
IDSSE-1038
Changes
This PR renames the "ims-service" to "NWS Connect Dummy Service", or "NCD" when a shorter name is needed.
Reorganization of files:
Added functionality:
ProfileStore
that reads and persists Support Profiles as JSON files on the filesystem/all-events?dataSource=ANY&status=existing
will return existing Support Profiles/all-events?dataSource=ANY&status=new
will return only newly added Support Profiles.A Support Profile will only ever appear in the "new" list one time; after that, it will be marked as "existing" (not new) and only be returned in the "existing" list.
Explanation
N/A