Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the length of varlist to hold more variables for recentering #54

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

chunhuazhou
Copy link
Contributor

DESCRIPTION OF CHANGES:

Increase the length of varlist to hold more variables for recentering.

TESTS CONDUCTED:

Tested on Jet

integer :: fv3_io_layout_y
character(len=filename_len) :: filebase
character(len=filename_len) :: filetail(max_num_file)
integer :: numvar(max_num_file)
character(len=filename_len) :: varlist(max_num_file)
character(len=varlist_len) :: varlist(max_num_file)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you don't need a new variable.
may use 500 directly just like what is done in module_fv3lam_stats.f90, :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either way works for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this new variable to be consistent with the rest of the code. But definitely can use 500 directly.

Copy link
Collaborator

@guoqing-noaa guoqing-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. It is not an import issue actually.
A better way may be to define 500 as a variable somewhere and both f90 files can refer the same variable.
However, it only involve two files, so explicitly setting 500 looks fine to me.

@chunhuazhou chunhuazhou merged commit ca6b673 into develop Nov 30, 2023
1 check passed
@chunhuazhou chunhuazhou deleted the recenter_varlist branch November 30, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants