Fix incorrect units in dtend metadata #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs a new baseline due to the different metadata in NetCDF output files. The baseline is here:
|
|
I need someone's approval of this PR to update the FV3 submodule to the top of gsl/develop. Until then, gsl/develop will be newer than its submodule hash. Pinging @DomHeinzeller and @ligiabernardet. I'll be gone most of today, so if it is approved, then it would be great if someone else merges in my absence. |
DomHeinzeller
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several units in dtend output variables had the wrong units (kg/(kg*s)). This is now corrected.
Corresponding fv3atm PR:
This error was discovered during review of the documentation PR:
Which was reviewed by @ligiabernardet
Note: This PR must not be merged until the submodule for FV3 is pointed back to NOAA-GSL. It points to SamuelTrahanNOAA so the branch can be recursively cloned and tested.