-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from setup.py
to pyproject.toml
; Update build scripts
#684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaraney, this look great!. I did make a few inline suggestions to add description
values in some of the .toml files where it was empty. I also changed one description
to remove a "MaaS" reference and replace with "DMOD," which is the only thing I think really needs to be changed.
{ name = "Robert Bartel" }, | ||
] | ||
dependencies = [ | ||
"dmod.core", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be the place to address it, but it is probably a bug that no version constraint for dmod.core
is specified here (likely also true for the next line and dmod.metrics
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, likely so. @christophertubbs, can you have a look at this?
1828ed0
to
d93f3ee
Compare
Co-authored-by: Robert Bartel <37884615+robertbartel@users.noreply.github.com>
d93f3ee
to
34a59ab
Compare
@robertbartel, thanks for adding package descriptions! Great teamwork! Just added all of your suggestions, @robertbartel, and squashed them so the history is a little cleaner and rebased off of master. Can you give it a quick re-review and get this on the road? |
Move from
setup.py
topyproject.toml
.Sub-package authorship is also updated.
Build scripts are also updated.
Replaces #683.
Closes #683.
Related to:
wheel
is installed at the beginning ofupdate_package.sh
#680Closes #248
Closes #247