Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from setup.py to pyproject.toml; Update build scripts #684

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jul 29, 2024

Move from setup.py to pyproject.toml.
Sub-package authorship is also updated.
Build scripts are also updated.

Replaces #683.
Closes #683.

Related to:

Closes #248
Closes #247

Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaraney, this look great!. I did make a few inline suggestions to add description values in some of the .toml files where it was empty. I also changed one description to remove a "MaaS" reference and replace with "DMOD," which is the only thing I think really needs to be changed.

{ name = "Robert Bartel" },
]
dependencies = [
"dmod.core",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may not be the place to address it, but it is probably a bug that no version constraint for dmod.core is specified here (likely also true for the next line and dmod.metrics).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, likely so. @christophertubbs, can you have a look at this?

@aaraney aaraney force-pushed the modernize-pkging branch from 1828ed0 to d93f3ee Compare July 31, 2024 15:20
@aaraney aaraney force-pushed the modernize-pkging branch from d93f3ee to 34a59ab Compare July 31, 2024 15:22
@aaraney
Copy link
Member Author

aaraney commented Jul 31, 2024

@robertbartel, thanks for adding package descriptions! Great teamwork!

Just added all of your suggestions, @robertbartel, and squashed them so the history is a little cleaner and rebased off of master. Can you give it a quick re-review and get this on the road?

@aaraney aaraney mentioned this pull request Jul 31, 2024
17 tasks
@robertbartel robertbartel merged commit e5f8846 into NOAA-OWP:master Jul 31, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants