Code

Ptl mbal testing#21

Code

Merged

ajkhattak merged 8 commits intomasterNOAA-OWP/LGAR-C:masterfrom PTL_mbal_testingNOAA-OWP/LGAR-C:PTL_mbal_testingCopy head branch name to clipboardApr 4, 2024

+260-104

Commits

Commits on Apr 2, 2024

• tested LASAM over approximately 40k parameter sets. Resolved mass balance errors and infinite loop errors that became apparent when LASAM was run with many parameter sets. Also updated field capaci…

  Show description for 82d63c3
  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  82d63c3

  Copy full SHA for 82d63c3

• tested LASAM over approximately 40k parameter sets. Resolved mass balance errors and infinite loop errors that became apparent when LASAM was run with many parameter sets. Also updated field capaci…

  Show description for 2b0bb13
  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  2b0bb13

  Copy full SHA for 2b0bb13

• updated unit test

  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  48b0f56

  Copy full SHA for 48b0f56

Commits on Apr 3, 2024

• updating with suggestions from PR review

  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  032072d

  Copy full SHA for 032072d

Commits on Apr 4, 2024

• Updated lgar.cxx in response to a few comments

  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  afc7673

  Copy full SHA for afc7673

• Removed a few comments that were not necessary

  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  ed41fc5

  Copy full SHA for ed41fc5

• when theta updates, it is now enforced to be greater than theta_r and less than theta_e

  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  5cc3d70

  Copy full SHA for 5cc3d70

• increased clarity of comment detailing how lgar_theta_mass_balance will never yield theta<theta_r

  

  Peter La Follette

  authored and

  Peter La Follette

  committed
  c2f0c79

  Copy full SHA for c2f0c79