Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn for Null values in series when calling event detection #124

Merged
merged 3 commits into from
Aug 9, 2021

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Aug 9, 2021

Warn the user if event detection is called on a series with null values. Closes #51

Additions

  • UserWarning when calling detrend_series that contains null values

Removals

  • None

Changes

  • None

Testing

  1. Warning is tested.

Notes

  • Docs/README still recommends to fill null values.

Todos

  • None

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the enhancement New feature or request label Aug 9, 2021
@jarq6c jarq6c self-assigned this Aug 9, 2021
@jarq6c
Copy link
Collaborator Author

jarq6c commented Aug 9, 2021

Passed all tests.

@jarq6c jarq6c merged commit 4c22c91 into NOAA-OWP:main Aug 9, 2021
@jarq6c jarq6c deleted the warn-events branch August 9, 2021 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate the influence of NaN values on event detection
1 participant