-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for complete categories when constructing contingency tables #184
Conversation
Tagging @aaraney |
@hellkite500 @aaraney any feedback on this PR? |
@hellkite500 @aaraney Following last week's meeting, I replaced all the complicated categorical checks with a simple I was also able to remove a step from the README example since the categorical conversion is now covered by the The only warning that's still raised is if the method encounters something that isn't one of the prescribed categories. These values are treated as NaN and the user is warned. |
Nice work on the refactor, by the way! Much simpler, and even more general! I like it! |
Thanks for the review! |
Approved, but I'll give @aaraney a chance to look it over before merging. |
This has been published to PyPI. |
sorry for being slow to get to this. having looked at it now, I would have approved the merge. like @hellkite500's noted, I think the refactor was done nicely. Nice work! |
Thanks @aaraney ! |
This adds a check and corrects missing boolean categories in Categorical series input to
compute_contingency_table
.Additions
True
andFalse
in observed and simulated input series.Removals
Changes
compute_contingency_table
.Testing
compute_contingency_table
that check for allTrue
and allFalse
cases.Notes
Todos
Checklist