-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nwis_client
CLI
#185
Add nwis_client
CLI
#185
Conversation
@aaraney I'm unable to add you as a reviewer until you comment. Any feedback you want to give? |
@jarq6c, thanks for pinging me. Id seen this, but had not had a chance to take a look. I certainly want to give you feedback / a review -- let me go ahead and do that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, @jarq6c! Ive added several comments. I think we can continue conversation through that avenue. Really excited to see where this goes.
This has been published to PyPI. |
This PR adds a minimal command-line interface to the
nwis_client
subpackage. The CLI entry point is callednwis-client
. Thenwis_client
README includes examples of use. Currently the tool generates a CSV based on an arbitrary number of USGS site codes (see usage/help output in README). It includes three optional parameters:--startDT
,--endDT
, and--parameterCd
.@aaraney
Additions
cli.py
Removals
Changes
value_time_label
now defaults tovalue_time
per Update nwis client to canonical format #117Testing
click
includes test funtionality perCLIRunner
, but this did not play well withasyncio
, so I implemented similar functionality usingsubprocess
.Notes
Todos
Checklist