-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add COE, COP, and volumetric efficiency to metrics
#195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only 'problems' I found were stylistic preferences, which is purely subjective.
I would like to eventually see quick documentation on what the metrics actually measure, instead of just directions to the papers, but that's just because I'm not a scientific user.
metrics
metrics
Thanks for the feedback! I decided to significantly expand the descriptions of all the metrics. Hopefully these new descriptions will help users unfamiliar with some of these. |
This PR implements a generic
mean_error_skill_score
method and adds three new metrics:coefficient_of_persistence
,coefficient_of_extrapolation
, andvolumetric_efficiency
. These three metrics are computed in a fashion similar to the Nash-Sutcliffe Model Efficiency, except instead of using the mean baseline they use a persistence, an extrapolation, and zero baseline. A "persistence" baseline uses the observed value given a lag. An extrapolation baseline uses the last two observed values to extrapolate a linear approximation.Added @hellkite500 and @aaraney may be interested.
Additions
mean_error
mean_squared_error
root_mean_squared_error
mean_error_skill_score
coefficient_of_persistence
coefficient_of_extrapolation
volumetric_efficiency
Removals
Changes
nash_sutcliffe_efficiency
is now based on the genericmean_error_skill_score
nash_sutcliffe_efficiency
Testing
Notes
hydrotools.metrics
Add coefficient of persistence and coefficient of extrapolation #147Todos
Checklist