Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin importlib-metadata version in nwm_client_new #221

Merged
merged 1 commit into from
May 19, 2023

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented May 19, 2023

Pin importlib-metadata<=4.13.0. Remove when 3.7 support dropped.

Fixes #211.

Changes

  • nwm_client_new dependency, importlib-metadata pinned to <=4.13.0

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@aaraney aaraney requested a review from jarq6c May 19, 2023 01:48
@jarq6c jarq6c merged commit 30d78eb into NOAA-OWP:main May 19, 2023
@aaraney
Copy link
Member Author

aaraney commented May 19, 2023

@jarq6c, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NWM Client New Test Failure: AttributeError: 'EntryPoints' object has no attribute 'get'
2 participants