Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow subpackage workflows in scope #225

Merged
merged 21 commits into from
Jun 8, 2023
Merged

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Jun 8, 2023

Separate the run_unit_tests.yml workflows into workflows for each subpackage.

Additions

  • separate yaml file workflows for each subpackage.

Removals

  • run_unit_tests.yml

Changes

  • Added a try/catch block in nwm_client_new when attempting to delete old files.

Testing

  1. Manually tested each new subpackage trigger.

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the enhancement New feature or request label Jun 8, 2023
@jarq6c jarq6c self-assigned this Jun 8, 2023
@jarq6c
Copy link
Collaborator Author

jarq6c commented Jun 8, 2023

Note: slow tests passed locally, except svi_client. See #217

@jarq6c jarq6c requested a review from aaraney June 8, 2023 18:52
@jarq6c
Copy link
Collaborator Author

jarq6c commented Jun 8, 2023

Note commit b4bed29 actually passed, but I cancelled the svi_client jobs before they finished.

@jarq6c jarq6c merged commit b1d7650 into NOAA-OWP:main Jun 8, 2023
@jarq6c jarq6c deleted the separate-workflows branch June 14, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move hydrotools namespace packages to separate repositories
1 participant