Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring svi_client field name maps into compliance with pydanic>2 #241

Merged
merged 3 commits into from
Oct 27, 2023
Merged

Bring svi_client field name maps into compliance with pydanic>2 #241

merged 3 commits into from
Oct 27, 2023

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Oct 27, 2023

fixes #240

hydrotools.svi_client [0.0.2] - 2023-10-27

Changes

  • Fix svi_client field name maps so they comply with pydanic>2.

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@aaraney aaraney added the bug Something isn't working label Oct 27, 2023
@aaraney aaraney self-assigned this Oct 27, 2023
@aaraney aaraney merged commit 94eded9 into NOAA-OWP:main Oct 27, 2023
@aaraney
Copy link
Member Author

aaraney commented Oct 27, 2023

https://pypi.org/project/hydrotools.svi-client/0.0.2/

@aaraney aaraney mentioned this pull request Oct 27, 2023
Closed
@aaraney aaraney deleted the fix_svi_client branch October 27, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aaraney aaraney

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVI Client get method failing due to Pydantic>2 issue
1 participant
@aaraney