Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default units handler to use explicit cache folder #254

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Jun 10, 2024

Closes #253

Changes the default unit registry cache to hydrotools/pint_cache. Added a new unit handler test to make sure pint actually uses the cache.

Checklist

  • PR has an informative and human-readable title
  • PR is well outlined and documented. See #12 for an example
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (see CONTRIBUTING.md)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output) using numpy docstring formatting
  • Placeholder code is flagged / future todos are captured in comments
  • Reviewers requested with the Reviewers tool ➡️

@jarq6c jarq6c added the bug Something isn't working label Jun 10, 2024
@jarq6c jarq6c self-assigned this Jun 10, 2024
@jarq6c
Copy link
Collaborator Author

jarq6c commented Jun 10, 2024

Passed all tests.

@jarq6c jarq6c merged commit d283d8d into NOAA-OWP:main Jun 10, 2024
4 checks passed
@jarq6c jarq6c deleted the update-units branch November 19, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pint caching fail leads to FileNotFoundError again. (nwm_client_new)
1 participant