Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add future warning to nwm_client_new about package name change. #267

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

jarq6c
Copy link
Collaborator

@jarq6c jarq6c commented Dec 3, 2024

This PR adds a FutureWarning to nwm_client_new to warn users about the impending name change, removes a now unnecessary check for python version pint compatibility, and bumps the package to 7.5.0.

Currently the old nwm_client raises a FutureWarning directing users to adopt nwm_client_new with a link to the PyPI landing page. Upon installing nwm_client_new users will get a FutureWarning that importing nwm_client will be preferred in the future when using nwm_client_new functionality for versions 8.0+. I guess this is what they call "technical debt."

@jarq6c jarq6c added the documentation Improvements or additions to documentation label Dec 3, 2024
@jarq6c jarq6c self-assigned this Dec 3, 2024
@jarq6c
Copy link
Collaborator Author

jarq6c commented Dec 3, 2024

@aaraney Not sure this needs a full-blown review, but I'm tagging you for awareness.

@jarq6c jarq6c merged commit 0ec21fd into NOAA-OWP:main Dec 3, 2024
5 checks passed
@jarq6c jarq6c deleted the nwm-client-new-dep branch December 3, 2024 15:08
@jarq6c jarq6c mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant