Add future warning to nwm_client_new about package name change.
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
FutureWarningtonwm_client_newto warn users about the impending name change, removes a now unnecessary check for python versionpintcompatibility, and bumps the package to 7.5.0.Currently the old
nwm_clientraises aFutureWarningdirecting users to adoptnwm_client_newwith a link to the PyPI landing page. Upon installingnwm_client_newusers will get aFutureWarningthat importingnwm_clientwill be preferred in the future when usingnwm_client_newfunctionality for versions 8.0+. I guess this is what they call "technical debt."