Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Infrastructure Point Service EGIS DB Ingestion and Static Service Creation #1045

Closed

Conversation

GeorgeRought-NOAA
Copy link
Contributor

Created mapx and yml for new critical infrastructure point static service.

Additions

Created Jupyter Notebook ingesting and documenting the ingestion of the critical infrastructure point service to the EGIS databsae.

Configured .mapx and .yml files to publish the new static critical infrastructure point service.

Removals

Changes

Testing

Database ingestion was tested in the dev schema of the viz db before migrating to the reference schema in the egis db

Screenshots

image

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • [x ] Windows
  • Linux
  • Browser

Accessibility

  • [x ] Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Jupyter Notebook output stream included email address leftover from testing arcgis.GIS login. No credentials are stored in the notebook.
…ervice_clean' into critical_infrastructure_static_service_clean

Merge
Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment to address before we can get this merged.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this shouldn't be in here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... definitely not. Somehow that got in, I've added it to gitignore.

@shawncrawley
Copy link
Collaborator

Oh wait, I didn't realize that this was closed... What happened there?

@GeorgeRought-NOAA
Copy link
Contributor Author

I saw that I had somehow accidentally pushed a change to python.exe in the .venv, and didn't want the PR to be approved and merged with that issue. So I temporarily closed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority - Medium Task 3 GAMA Task 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New Critical Infrastructure as Points Static Service
2 participants