Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Infrastructure Point Service EGIS DB Ingestion and Static Service Creation Revision #1046

Merged
merged 9 commits into from
Jan 16, 2025

Conversation

GeorgeRought-NOAA
Copy link
Contributor

Created Jupyter Notebook to document the ingestion of critical infrastructure point data into the EGIS database. Mapx and yml files were created for a new critical infrastructure point static service.

Additions

Created Jupyter Notebook ingesting and documenting the ingestion of the critical infrastructure point service to the EGIS databsae.

Configured .mapx and .yml files to publish the new static critical infrastructure point service.

Removals

Changes

Updated documentation for the source of the critical infrastructure data and the ingestion process. Fixed an issue where a python.exe file was included from the virtual environment in vscode in the last push.

Testing

Database ingestion was tested in the dev schema of the viz db before migrating to the reference schema in the egis db

Screenshots

403970962-ed773a8a-e0c7-4871-8531-05332bf9c02d

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

Copy link
Collaborator

@shawncrawley shawncrawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks, George.

@shawncrawley shawncrawley merged commit 763cb4c into ti Jan 16, 2025
1 check passed
@shawncrawley shawncrawley deleted the critical_infrastructure_static_service_clean branch January 16, 2025 21:50
@nickchadwick-noaa nickchadwick-noaa modified the milestones: V2.x.x, V2.2.0 Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority - Medium Task 3 GAMA Task 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create New Critical Infrastructure as Points Static Service
3 participants