Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set_value adjust #45

Merged
merged 2 commits into from
Sep 13, 2024
Merged

set_value adjust #45

merged 2 commits into from
Sep 13, 2024

Conversation

madMatchstick
Copy link
Contributor

Readjusts implementation of set_value() to a previous definition. There was a lot of back and forth with how closely bmi definitions followed the csdms examples. The functionality here was overlooked. Recommend reverting back to something working for the time being.

See discussion linked below for the full details.

Addresses issue #43

Changes

  • set_value() functions properly via use of internal_array again.

Testing

  • At glance, standalone results are producing more reasonable discharge.

@madMatchstick madMatchstick marked this pull request as draft June 24, 2024 16:59
@madMatchstick madMatchstick marked this pull request as ready for review July 11, 2024 17:47
Copy link
Member

@hellkite500 hellkite500 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is moving the right direction, further refactoring can clean up the implementation, but at least now, set_value is actually modifying data the model uses to make predicitons.

@hellkite500 hellkite500 merged commit 44a16c1 into master Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants