You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#437 fixed this issue for BMI formulations, but it also needs to be addressed with the non-BMI formulations (Simple_Lumped, t_shirt). Believe these are Catchment_Formulation subclasses, so the same approach should be usable... if not, reassess.
Current behavior
These formulations will not pass a catchment ID to the DataProvider selector, so they will get data from an undefined (usually first) catchment.
Expected behavior
Should pass a catchment ID to the selector
Steps to replicate behavior (include URLs)
Screenshots
The text was updated successfully, but these errors were encountered:
@stcui007 Can you have a look at this with Simple_Lumped and t_shirt realizations? I don't remember if this is still outstanding, but I think it is. Basically similar changes need to be made to Simple_Lumped and t_shirt as those in #437 (and #432).
#437 fixed this issue for BMI formulations, but it also needs to be addressed with the non-BMI formulations (Simple_Lumped, t_shirt). Believe these are
Catchment_Formulation
subclasses, so the same approach should be usable... if not, reassess.Current behavior
These formulations will not pass a catchment ID to the DataProvider selector, so they will get data from an undefined (usually first) catchment.
Expected behavior
Should pass a catchment ID to the selector
Steps to replicate behavior (include URLs)
Screenshots
The text was updated successfully, but these errors were encountered: