Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy formulations to pass catchment ID to CatchmentAggrDataSelector #439

Closed
mattw-nws opened this issue Aug 26, 2022 · 2 comments · Fixed by #480
Closed

Fix legacy formulations to pass catchment ID to CatchmentAggrDataSelector #439

mattw-nws opened this issue Aug 26, 2022 · 2 comments · Fixed by #480
Assignees

Comments

@mattw-nws
Copy link
Contributor

#437 fixed this issue for BMI formulations, but it also needs to be addressed with the non-BMI formulations (Simple_Lumped, t_shirt). Believe these are Catchment_Formulation subclasses, so the same approach should be usable... if not, reassess.

Current behavior

These formulations will not pass a catchment ID to the DataProvider selector, so they will get data from an undefined (usually first) catchment.

Expected behavior

Should pass a catchment ID to the selector

Steps to replicate behavior (include URLs)

Screenshots

@mattw-nws
Copy link
Contributor Author

Notably, #432 now fixes this for LSTM_Realization.

@mattw-nws
Copy link
Contributor Author

@stcui007 Can you have a look at this with Simple_Lumped and t_shirt realizations? I don't remember if this is still outstanding, but I think it is. Basically similar changes need to be made to Simple_Lumped and t_shirt as those in #437 (and #432).

@mattw-nws mattw-nws linked a pull request Dec 9, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants