Passing catchment id to CatchmentAggrDataSelector

[stcui007]

Passing catchment id in place of an empty string in get_value function.

Additions

Removals

Changes

src/realizations/catchment/Simple_Lumped_Model_Realization.cpp
src/realizations/catchment/Tshirt_C_Realization.cpp
src/realizations/catchment/Tshirt_Realization.cpp

Testing

1. Various Unit tests
2. Run ngen

Screenshots

Notes

Todos

Checklist

• [x ] PR has an informative and human-readable title
• [x ] Changes are limited to a single goal (no scope creep)
• [x ] Code can be automatically merged (no conflicts)
• [x ] Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

• [x ] Linux

[mattw-nws]

End result of this change is that the same thing is in thetry and catch blocks. I think that the new DataProviders will reconcile these two different names so the try/catch is now unnecessary... remove the try/catch block and replace with just the one line.

[mattw-nws]

This is never used anywhere, please remove.

[stcui007]

Will do. Thanks.

…

On Fri, Dec 9, 2022 at 3:21 PM Matt Williamson ***@***.***> wrote: ***@***.**** requested changes on this pull request. ------------------------------ In src/realizations/catchment/Simple_Lumped_Model_Realization.cpp <#480 (comment)>: > try { - precip = this->forcing->get_value(CatchmentAggrDataSelector("","precip_rate", t_unix, dt, "")); // classic forcing object/format + precip = this->forcing->get_value(CatchmentAggrDataSelector(this->id, CSDMS_STD_NAME_LIQUID_EQ_PRECIP_RATE, t_current, t_delta_s, ""), data_access::SUM); End result of this change is that the same thing is in thetry and catch blocks. I think that the new DataProviders will reconcile these two different names so the try/catch is now unnecessary... remove the try/catch block and replace with just the one line. ------------------------------ In src/realizations/catchment/Simple_Lumped_Model_Realization.cpp <#480 (comment)>: > double precip; - time_t t_unix = this->forcing->get_data_start_time() + (t * 3600); + const std::string forcing_name = CSDMS_STD_NAME_LIQUID_EQ_PRECIP_RATE; This is never used anywhere, please remove. — Reply to this email directly, view it on GitHub <#480 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACA4SRNWB2BQMPMKSMRY64DWMOPGJANCNFSM6AAAAAASJEDA74> . You are receiving this because you authored the thread.Message ID: ***@***.***>