Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example realization file tune-up/catch-up after #448 and #430 #453

Closed
mattw-nws opened this issue Oct 11, 2022 · 0 comments · Fixed by #460
Closed

Example realization file tune-up/catch-up after #448 and #430 #453

mattw-nws opened this issue Oct 11, 2022 · 0 comments · Fixed by #460

Comments

@mattw-nws
Copy link
Contributor

#448 points out some needs to update example realization files. CFE can no longer serve as a single C formulation example, and the Linux/macOS pair of examples are now redundant after #430.

Current behavior

After #448, the "bmi_c" examples are no longer examples of bmi_c formulations, instead they are bmi_multi. Also the "_linux" and "_macos" realization config file pairs are redundant after #430.

Expected behavior

Change the "bmi_c" example files to use the test_bmi_c module instead. Remove any duplicative pairs of example (or test) configs that are OS specific and replace them with a single file--preferably using only the "extensionless" method of pointing to library files.

Steps to replicate behavior (include URLs)

Screenshots
@mattw-nws mattw-nws mentioned this issue Oct 11, 2022
Merged
10 tasks
@mattw-nws mattw-nws mentioned this issue Oct 24, 2022
Merged
10 tasks
@mattw-nws mattw-nws linked a pull request Nov 3, 2022 that will close this issue
Fix for #453 #460
Merged
10 tasks
mattw-nws pushed a commit that referenced this issue Nov 3, 2022
@stcui007
Fix for #453 (#460)
e5cf1b7 
* Setting up some config json files

* Revised namelist.input files

* Fixing github testing issue

* Revised version based on comments

* Change <std::string> back to <string> in NexusTests.cpp

* Add examples of test_bmi_c

* Removing test_bmi_c part from example_bmi_multi_realization_config.json as it exists in another example

* Revise config json to run purely bmi_c models.

* Clean up some formatting of config json file.

* Fix a bug in the previous version of config json file.

* Some clean up associated with the use of new Linux/Mac realization config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #453 stcui007/ngen
1 participant
@mattw-nws