generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bmi parameter initialization integration #368
Merged
robertbartel
merged 19 commits into
NOAA-OWP:master
from
hellkite500:bmi_calibration_parameters
Mar 15, 2022
Merged
Bmi parameter initialization integration #368
robertbartel
merged 19 commits into
NOAA-OWP:master
from
hellkite500:bmi_calibration_parameters
Mar 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellkite500
force-pushed
the
bmi_calibration_parameters
branch
from
February 15, 2022 20:05
ef4d79e
to
9c99e93
Compare
hellkite500
force-pushed
the
bmi_calibration_parameters
branch
from
March 3, 2022 18:54
9c99e93
to
2f2e9c9
Compare
hellkite500
force-pushed
the
bmi_calibration_parameters
branch
from
March 11, 2022 16:47
e04fd27
to
ea14565
Compare
robertbartel
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the ngen framework to read a model parameter key in the realization configuration and, once a BMI model has been initialized, it will use
Set_value
to modify the parameter values of the BMI model to use the ones read from the ngen configuration.Additions
model_params
optional key in the configuration input file.JSONProperty::PropertyVariant
memberJSONProperty::PropertyVistor
structJSONProperty::as_vector()
template functionBMI_Module_Formulation:
as_c_array()
get_values_as_types()
Removals
Changes
model_params
in the passed property tree and attempt toSet_value
for those parameter variables.Testing
ngen_cal
to support calibration iterations.Screenshots
Notes
Set_value
for the respective parameter variables.Todos
Checklist
Target Environment support