precip_rate now computed using the right unit of temperature

[hellkite500]

Discovered a bug in the script used to generate the example forcing files. The density of water is computed using the following function:

 def rho(temp):
     """
         Calculate water density at temperature (degrees C)
     """
     return 999.99399 + 0.04216485*temp - 0.007097451*(temp**2) + 0.00003509571*(temp**3) - 9.    9037785E-8*(temp**4)

But the AORC temperature variable is in kelvin, and was being passed without converting to celsius.

Fixed this in the script and regenerated the example forcing data files to get correct precip_rate (in m/s)

Changes

• There example forcing data files with corrected precip_rate column

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

[mattw-nws]

Looks like the Fortran tests--maybe others--have expected result values based on the old incorrect precip_rate data. I was afraid of that when we found the issue, since I was about to base an updated test on the same values.

[hellkite500]

Looks like the Fortran tests--maybe others--have expected result values based on the old incorrect precip_rate data. I was afraid of that when we found the issue, since I was about to base an updated test on the same values.

I'm updating those now...

[mattw-nws]

I'll be kind of surprised if the -0 thing only happens on C and not C++ ... but we can keep an eye on it.