Add SoilMoistureProfile and SoilFreeThaw as git submodule in ngen ext…

[champham]

Add SoilMoistureProfile and SoilFreeThaw as git submodule in ngen external directory.

Additions

• extern/SoilMoistureProfiles/{README.md,INSTALL.md,SoilMoistureProfiles}
• extern/SoilFreezeThaw/{README.md,INSTALL.md,SoilFreezeThaw}

Removals

Changes

• .gitmodules

Testing

1. Clone the submodules
2. Build the libsmpbmi and libsftbmi shared libraries

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

• Linux

[mattw-nws]

Apparently for this module the command needs to be:

cmake -B cmake_build -S . -DNGEN=1

Otherwise the library tries to find cfe.c and fails to configure.

[champham]

I added -DNGEN=1 for both SoilFreezeThaw and SoilMoistureProfiles INSTALL.md.

[mattw-nws]

This is likely to lead to confusion... let's make these all SoilMoistureProfiles (with an s), since that is apparently the name of the repo.

[mattw-nws]

Notably, the submodule addition itself probably needs to be changed--I am not sure that just changing the path in this file will suffice...and I'm not sure how to otherwise edit it, it may need to be removed and re-added. (?)

[champham]

I removed and re-added SoilMoistureProfiles.

[mattw-nws]

This is all good now I think... however, can you rebase on master again? There is a fix in master that should make the tests pass.

[champham]

I've rebased the ngen.sft branch onto master. commit e4d923d Merge: 6c2cf14 b096668 Author: champham ***@***.***> Date: Fri May 6 09:38:32 2022 -0400 Merge branch 'NOAA-OWP:master' into ngen.sft commit b096668 Author: Matt Williamson ***@***.***> Date: Thu May 5 08:33:52 2022 -0500 try --fix-missing as error suggests

…

On Fri, May 6, 2022 at 9:16 AM Matt Williamson ***@***.***> wrote: This is all good now I think... however, can you rebase on master again? There is a fix in master that should make the tests pass. — Reply to this email directly, view it on GitHub <#412 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFLRAXDTVJLRZA4UUFAKYOLVIULRVANCNFSM5UQYXYZQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>