Optimize unit conversion by reusing cv_converters
#420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellkite500
reviewed
Jun 10, 2022
| const std::lock_guard<std::mutex> lock(converters_mutex); | ||
|
|
||
| std::string key = in_units + "|" + out_units; //Better solution? Good enough? Bother with nested maps? |
There was a problem hiding this comment.
depends on what is "faster", string concat and then hash, or two hashes?
There was a problem hiding this comment.
Yeah, that, but I was actually thinking more about if | is somehow a valid character in a unit definition (probably not??) and/or if we could hit string encoding issues that this operator and std::string can't handle...no idea there.
|
|
11 tasks
|
Hmm... noting that this will probably conflict with #405, which should probably be merged first. |
mattw-nws
force-pushed
the
udunits-optimize
branch
from
df06259 to
9280e40
Compare
|
Rebased after #405 ... please reassess! |
hellkite500
approved these changes
Jul 12, 2022
donaldwj
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callgrind analysis showed a >10% of runtime spent in
get_converted_valuelargely because ofut_parsewhen creating unit representations. This was a known unoptimized point, but the impact was higher than expected. This PR optimizes the unit conversion pipeline.Additions
Removals
Changes
Testing
Screenshots
Notes
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support