Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPI Broadcast Call Bugfix #424

Merged
merged 2 commits into from
Jul 26, 2022
Merged

MPI Broadcast Call Bugfix #424

merged 2 commits into from
Jul 26, 2022

Conversation

mattw-nws
Copy link
Contributor

Fixes MPI crash that manifested when using hydrofabric subdividing... but probably can (should?) occur elsewhere.

Additions

Removals

Changes

  • Corrected value sent to parameter count which should have always been 1.

Testing

  1. Prevents reproducible crash when using hydrofabric subdivision feature.

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

donaldwj
donaldwj approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@donaldwj donaldwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this months ago

@mattw-nws mattw-nws merged commit aec292f into NOAA-OWP:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldwj donaldwj donaldwj approved these changes

@robertbartel robertbartel Awaiting requested review from robertbartel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattw-nws @donaldwj