Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SLoTH as a default module in extern #433

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Adding SLoTH as a default module in extern #433

merged 2 commits into from
Aug 18, 2022

Conversation

mattw-nws
Copy link
Contributor

Adds SLoTH module for fixed-value input injection into BMI stacks.

Additions

  • Added extern... tracks latest branch.

Removals

Changes

  • Minor tweaks to gitpod.yml

Testing

  1. See SLoTH repo

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

  • Linux

@mattw-nws mattw-nws marked this pull request as ready for review August 11, 2022 19:36
robertbartel
robertbartel approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@robertbartel robertbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing caught my eye to just point out, but my guess is it's fine, so I am approving.

It might be good to create a Github issue to, in the future, expand the documentation related to this.

.gitpod.yml
@@ -11,14 +11,16 @@ tasks:
cmake -S extern/test_bmi_c -B extern/test_bmi_c/cmake_build
cmake -S extern/test_bmi_cpp -B extern/test_bmi_cpp/cmake_build
cmake -S extern/test_bmi_fortran/ -B extern/test_bmi_fortran/cmake_build
cmake -S extern/evapotranspiration/ -B extern/evapotranspiration/cmake_build
cmake -S extern/sloth -B extern/sloth/cmake_build
cmake -S extern/evapotranspiration/evapotranspiration -B extern/evapotranspiration/cmake_build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to worry about this being out of scope (although that's why it caught my attention), but I do want to make sure it is intentional and correct.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's a little bug I found... yes slightly out of scope.

@mattw-nws mattw-nws merged commit e310b57 into NOAA-OWP:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbartel robertbartel robertbartel approved these changes

@hellkite500 hellkite500 Awaiting requested review from hellkite500

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattw-nws @robertbartel