Basic fix to make sure NetCDF files get closed

[mattw-nws]

Fixes #481. Seems to do the job in serial and parallel builds.

Additions

• static function data_access::NetCDFPerFeatureDataProvider::cleanup_shared_providers()

Removals

Changes

• Calls above static function in Formulation_Manager destructor.

Testing

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

1. Passing all auto tests. Tested on data in ./data/forcing with mixed realization with NetCDF and CSV forcing in different catchments, serial and parallel builds (2 partitions). Not seeing any H5Dclose errors.

Target Environment support

• Linux

[hellkite500]

Two notes:

Should probably add a simple unit test of the cleanup function...

I would consider adding the cleanup_shared_providers to the DataProvider interface as a virtual function...or we could go a step further and build a SharedDataProvider subclass if we think there are enough significant differences between shared providers and non-shared...