Modify Formulation_Manager.hpp to parse forcing "file_pattern"

[stcui007]

This commit enable ngen to parse forcing "file_pattern" in explicit catchments formulation.

Additions

data/test_bmi_multi_realization_config.json
data/test_bmi_multi_realization_config_w_netcdf.json
data/test_bmi_multi_realization_config_w_noah_pet_cfe.json
data/test_realization_config.json

Removals

Changes

include/realizations/catchment/Formulation_Manager.hpp

Testing

unit tests
run ngen tests in serial
run ngen tests in parallel

Screenshots

Notes

Todos

Checklist

• [x ] PR has an informative and human-readable title
• [x ] Changes are limited to a single goal (no scope creep)
• [x ] Code can be automatically merged (no conflicts)
• [x ] Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist (automated report can be put here)

Target Environment support

• [x ] Linux

[mattw-nws]

This looks promising... I will try testing with the files tomorrow... could you try adding an automated test for this? Would probably make sense in Formulation_Manager_Test.cpp.

[stcui007]

Yes, sure.

…

On Thu, Jan 12, 2023 at 4:04 PM Matt Williamson ***@***.***> wrote: This looks promising... I will try testing with the files tomorrow... could you try adding an automated test for this? Would probably make sense in Formulation_Manager_Test.cpp. — Reply to this email directly, view it on GitHub <#489 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACA4SRM7O3E5SSGYMF6OFM3WSB5YFANCNFSM6AAAAAATZUOZ3E> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[hellkite500]

Generally looks good to me. Doesn't change the existing semantics but allows significant code reuse! My only concern is the test coverage now doesn't consider the case when an explicit path is passed.

[hellkite500]

I would leave one or two of these tests with just the path and not pattern to ensure that both cases work.

[stcui007]

If there is no disagreement, I'll implement Nels' suggestion.

…

On Tue, Jan 17, 2023 at 10:48 AM Nels ***@***.***> wrote: ***@***.**** requested changes on this pull request. Generally looks good to me. Doesn't change the existing semantics but allows significant code reuse! My only concern is the test coverage now doesn't consider the case when an explicit path is passed. ------------------------------ In test/realizations/Formulation_Manager_Test.cpp <#489 (comment)>: > @@ -608,7 +620,9 @@ const std::string EXAMPLE_4 = "{ " "} " "], " "\"forcing\": { " - "\"path\": \"./data/forcing/cat-67_2015-12-01 00_00_00_2015-12-30 23_00_00.csv\" " I would leave one or two of these tests with just the path and not pattern to ensure that both cases work. — Reply to this email directly, view it on GitHub <#489 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACA4SRITFQ3WCVN3Z3XAKFDWS3ENTANCNFSM6AAAAAATZUOZ3E> . You are receiving this because you authored the thread.Message ID: ***@***.***>