Add stdexcept include to UnitsHelper header #524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #523 by including
<stdexcept>
inUnitsHelper.hpp
. Inlibstdc++
version 13.1.0, the<mutex>
header removed an include to<system_error>
, which also removed includes to<stdexcept>
and<string>
. This causedstd::string
andstd::runtime_error
to raise errors on compilation of targetcore_mediator
.Additions
<stdexcept>
toinclude/core/mediator/UnitsHelper.hpp
.Testing
core_mediator
compiles successfully and all unit tests pass locally usinglibstdc++
andlibc++
with GCC version 13.1.0, clang 15.0.7, and icx 2023.Checklist
Target Environment support