Ensure forcing path when file_pattern configured. #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This change enforces requiring a
path
wheneverfile_pattern
is present in forcing params in a realization config.Explanation
The addition of
NullForcingProvider
included support for the absence of apath
value fromforcing
in a realization config.Those changes did not fully account for user errors involving omitting the
path
in other situations, in particular when afile_pattern
is configured; e.g., doing thisinstead of this
Now an error will be thrown explaining that
path
needs to be set to the parent directory.