Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Fix old mistake to make ctest pass independent of working directory #693

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Dec 28, 2023

Changes

  • There is no variable PROJECT_DIR, it seems PROJECT_BINARY_DIR was intended.

Testing

  1. Run ctest in either a build tree root, or in test/ within that tree. All tests pass either way.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • macOS

…ctory

There is no variable PROJECT_DIR, it seems PROJECT_BINARY_DIR was intended.
@PhilMiller PhilMiller requested a review from program-- December 28, 2023 00:07
@program-- program-- merged commit 86a8443 into NOAA-OWP:master Dec 28, 2023
19 checks passed
@PhilMiller PhilMiller deleted the phil/cmake-dir branch December 28, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants