-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timing output to the end of ngen runs #696
Conversation
The inter-mixed conditions of MPI and Routing being active were confusing. Additionally, running routing after calling MPI_Finalize is inadvisable. Per the MPICH documentation, > The number of processes running after this routine is called is > undefined; it is best not to perform much more than a return rc > after calling MPI_Finalize.
The refactoring of the ifdef logic was because I wanted to use the same test for printing the timings, and didn't want to make a mess there. |
Ugh, and of course in tweaking things between my last local build and pushing, I broke it a bit. That'll be fixed shortly. |
This will greatly help with hardware affinity testing. Ideally we should be able to give some rough numbers about the relationship between domain extent, available hardware, and expected runtime. Thanks, |
I'll leave it to others to formally approve, but I like it overall. Thanks for putting this together @PhilMiller. |
1094c1b
to
6c8cb15
Compare
Ideally, the textual numeric output would be presented a little more readably, using something like https://github.com/martinmoene/EngFormat-Cpp but that's an inessential refinement, compared to just getting meaningful measurements in place. All previous comments on the code addressed. |
@PhilMiller
|
@ZacharyWills Seconds |
This will allow for slightly more informative benchmark results, in which we can distinguish different elements of the runtime, and extrapolate accordingly.
Changes
#ifdef
logicTesting
Screenshot
From the CI job running on example data:
Todos
Checklist
Target Environment support