Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Boost 1.79 across the board #713

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Jan 22, 2024

Bump our dependency on Boost 1.72 up to 1.79, based on the newer version's availability in the WCOSS2 production environment. Anywhere else, we can install whatever version we like.

Closes #700

Removals

  • Private copies of Boost's implementation of span and data that were introduced between 1.72 and 1.79

Changes

  • Update scripts and documentation to reference the newer version
  • CMake requires at least 1.79
  • Update #include across the code to reference the Boost header directly

Testing

  1. CI

Notes

  • There may be other documentation not directly in the master branch of our repository that will need to change in tandem

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

@PhilMiller PhilMiller marked this pull request as ready for review January 22, 2024 22:16
@hellkite500 hellkite500 merged commit a409439 into NOAA-OWP:master Jan 23, 2024
19 checks passed
@PhilMiller PhilMiller deleted the 700-boost-179 branch January 23, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update baseline Boost to version 1.79
2 participants