Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errno reporting to bad file reads #715

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

hellkite500
Copy link
Member

@hellkite500 hellkite500 commented Jan 24, 2024

Additional error reporting when file reads fail to occur, this provides additional context as to why the failure happens.

Changes

  • Capture and report the errno when certain file reads fail

Todos

  • May need to check other possible locations of file read errors and extend their error messaging similarly

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • MacOS

@PhilMiller PhilMiller changed the title add errorno reporting to bad file reads Add errno reporting to bad file reads Jan 25, 2024
@hellkite500 hellkite500 merged commit efcdd17 into NOAA-OWP:master Jan 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants