Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NOAH-OWP-Modular can be built manually #731

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

program--
Copy link
Contributor

@program-- program-- commented Feb 12, 2024

This PR resolves #730 by ensuring iso_c_fortran_bmi is part of the NOAH-OWP-Modular build when it is built manually. To ensure NOAH-OWP-Modular is built with NGen support, when configuring, the CMake option -DNGEN_IS_MAIN_PROJECT must be set to ON.

Changes

  • Add iso_c_fortran_bmi as a dependent CMake subdirectory to the NOAH-OWP-Modular build.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Target Environment support

  • Linux
  • macOS

@program-- program-- added bug Something isn't working build Issues related to CMake and building ngen labels Feb 12, 2024
@program-- program-- self-assigned this Feb 12, 2024
Copy link
Contributor

@stcui007 stcui007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able build the build the noah-owp-modular libsurfacebmi.so successfully without any error. So it looks like the fix works.

@program-- program-- merged commit 4c10f10 into NOAA-OWP:master Feb 13, 2024
19 checks passed
@program-- program-- deleted the jsm-nom-fix-730 branch February 13, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build Issues related to CMake and building ngen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with building noah-owp-modular shared library
2 participants