generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentations for the latest ngen #742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stcui007
requested review from
program--,
robertbartel,
hellkite500 and
PhilMiller
February 26, 2024 16:27
program--
reviewed
Feb 26, 2024
program--
previously approved these changes
Feb 28, 2024
program--
reviewed
Mar 1, 2024
Oh, thank you. I got that from git ngen-build yaml. I am changing it now.
…On Fri, Mar 1, 2024 at 12:50 PM Justin Singh-M. - NOAA < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In doc/DEPENDENCIES.md
<#742 (comment)>:
> @@ -6,15 +6,16 @@
| ------------- |:------------- | :-----:| :-------: |
| [Google Test](#google-test) | submodule | `release-1.10.0` | |
| [C/C++ Compiler](#c-and-c-compiler) | external | see below | |
-| [CMake](#cmake) | external | \>= `3.14` | |
+| [CMake](#cmake) | external | \>= `3.15` | |
Didn't catch this before, but the minimum version required for CMake is
3.17, see the root CMakeLists.txt.
—
Reply to this email directly, view it on GitHub
<#742 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACA4SRKSASTEHPNNWVKOXETYWDEXJAVCNFSM6AAAAABDMT73LSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJRHAYTMMRZGU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
program--
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates several documentations so that the build of module libraries, test modules, and ngen build options and environment reflect the most recent refactoring in the CMake build structure of ngen. In addition, it updates the routing_config.yaml so that it works with the current t-route. The previous version no longer works. It also add a few tips for building the nwm-routing module.
Additions
Removals
Changes
data/gauge_01073000/routing_config.yaml
doc/BMI_MODELS.md
doc/DEPENDENCIES.md
doc/DISTRIBUTED_PROCESSING.md
doc/MPI_REMOTE_NEXUS.md
doc/REALIZATION_CONFIGURATION.md
doc/PYTHON_ROUTING.md
test/README.md
./README.md
./INSTALL.md
Testing
Screenshots
Notes
Work in progress
Todos
Checklist
Testing checklist (automated report can be put here)
Target Environment support