generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formulation configuration refactoring #745
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig (no longer _from_tree)
hellkite500
force-pushed
the
formulation-refac
branch
from
February 26, 2024 17:40
c03a512
to
6e872f6
Compare
program--
reviewed
Feb 26, 2024
program--
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #743. This will nearly decouple Formulation_Manager from boost ptrees. There are still a couple places which are dependent on the ptree, but it is now only the highest level of extracting the main components and building configuration strcutures which are used throughout the rest of the formulation manager code.
Additions
Removals
Changes
construct_formulation_from_tree
renamed toconstruct_formulation_from_config
and no longer requires any ptree inputs, but instead uses the constructed configuration objects.Testing
Todos
Checklist
Target Environment support