Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues in tests #780

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

PhilMiller
Copy link
Contributor

@PhilMiller PhilMiller commented Mar 28, 2024

In a build with Fortran disabled, I noticed the MultiLayerParserTest failing, and that the error message had a small typo.

Changes

  • Add a space and quote the named module in the error message
  • Disable the test when BMI Fortran is unavailable

Testing

  1. With just the source changes, the error message looks better
  2. With the CMake change, the test isn't built or run

Notes

Wait until my earlier PR is merged, since this branch builds on it

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

test/CMakeLists.txt Outdated Show resolved Hide resolved
@PhilMiller PhilMiller force-pushed the PhilMiller/fortran-test branch from 0b5b0db to b4181be Compare March 28, 2024 19:17
@PhilMiller PhilMiller marked this pull request as ready for review March 28, 2024 19:19
@PhilMiller PhilMiller merged commit a788ca4 into NOAA-OWP:master Mar 28, 2024
19 checks passed
@PhilMiller PhilMiller deleted the PhilMiller/fortran-test branch March 28, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants